[PATCH] D22462: [ARM][LLD] Initial support for ARM TLS

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 08:05:12 PDT 2016


ruiu added a comment.

Code LGTM, but these tests seems too long to me. As a comparison, test/ELF/aarch64-tls-gdie.s is just 34 lines. Can you reduce the test assembly so that you really test the feature that you are adding?


================
Comment at: ELF/Target.cpp:1522
@@ -1518,1 +1521,3 @@
+  case R_ARM_TLS_IE32:
+    // GOT(S) + - P
     return R_GOT_PC;
----------------
`+ -`?


https://reviews.llvm.org/D22462





More information about the llvm-commits mailing list