[PATCH] D22453: [Compiler-rt][MIPS] Fix simple test failure when using gcc

Mohit Bhakkad via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 23:11:26 PDT 2016


mohit.bhakkad created this revision.
mohit.bhakkad added a reviewer: dsanders.
mohit.bhakkad added subscribers: llvm-commits, Sanitizers, jaydeep, slthakur.
mohit.bhakkad set the repository for this revision to rL LLVM.
Herald added a reviewer: vkalintiris.

n64  is invalid argument to -mabi for gcc compiler:

```
gcc: error: unrecognized argument in option ‘-mabi=n64’
gcc: note: valid arguments to ‘-mabi=’ are: 32 64 eabi n32 o64
```
and in clang both -mabi=n64 and -mabi=64 points to n64 abi.

Repository:
  rL LLVM

https://reviews.llvm.org/D22453

Files:
  cmake/base-config-ix.cmake

Index: cmake/base-config-ix.cmake
===================================================================
--- cmake/base-config-ix.cmake
+++ cmake/base-config-ix.cmake
@@ -148,10 +148,10 @@
       # since the default ABI differs between gcc and clang.
       # FIXME: Ideally, we would build the N32 library too.
       test_target_arch(mipsel "" "-mips32r2" "--target=mipsel-linux-gnu")
-      test_target_arch(mips64el "" "-mips64r2" "--target=mips64el-linux-gnu" "-mabi=n64")
+      test_target_arch(mips64el "" "-mips64r2" "--target=mips64el-linux-gnu" "-mabi=64")
     elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "mips")
       test_target_arch(mips "" "-mips32r2" "--target=mips-linux-gnu")
-      test_target_arch(mips64 "" "-mips64r2" "--target=mips64-linux-gnu" "-mabi=n64")
+      test_target_arch(mips64 "" "-mips64r2" "--target=mips64-linux-gnu" "-mabi=64")
     elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "arm")
       test_target_arch(arm "" "-march=armv7-a" "-mfloat-abi=soft")
       test_target_arch(armhf "" "-march=armv7-a" "-mfloat-abi=hard")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22453.64274.patch
Type: text/x-patch
Size: 1076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160718/03c5b4d1/attachment.bin>


More information about the llvm-commits mailing list