[llvm] r275706 - Address review comments.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 08:06:34 PDT 2016


Sorry about this noisy commit! I didn't properly merge together all the git
revisions on my branch before committing D21932/r275707. This and the other
mistake commit r275705 cancel each other out.

On Sun, Jul 17, 2016 at 7:46 AM, Teresa Johnson via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: tejohnson
> Date: Sun Jul 17 09:46:58 2016
> New Revision: 275706
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275706&view=rev
> Log:
> Address review comments.
>
> Modified:
>     llvm/trunk/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
>
> Modified:
> llvm/trunk/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp?rev=275706&r1=275705&r2=275706&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
> (original)
> +++ llvm/trunk/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
> Sun Jul 17 09:46:58 2016
> @@ -275,6 +275,14 @@ ICallPromotionFunc::getPromotionCandidat
>      DEBUG(dbgs() << " Candidate " << I << " Count=" << Count
>                   << "  Target_func: " << Target << "\n");
>
> +    if (ICPInvokeOnly && dyn_cast<CallInst>(Inst)) {
> +      DEBUG(dbgs() << " Not promote: User options.\n");
> +      break;
> +    }
> +    if (ICPCallOnly && dyn_cast<InvokeInst>(Inst)) {
> +      DEBUG(dbgs() << " Not promote: User option.\n");
> +      break;
> +    }
>      if (ICPCutOff != 0 && NumOfPGOICallPromotion >= ICPCutOff) {
>        DEBUG(dbgs() << " Not promote: Cutoff reached.\n");
>        break;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160717/ddbde8b0/attachment.html>


More information about the llvm-commits mailing list