[PATCH] D22437: [LoopDist] Port to new PM

[Adam Nemet via llvm-commits]

anemet added inline comments.

================
Comment at: lib/Transforms/Scalar/LoopDistribute.cpp:962
@@ +961,3 @@
+
+  for (Loop *TopLevelLoop : LI)
+    for (Loop *L : depth_first(TopLevelLoop))
----------------
silvas wrote:
> Usually we have been factoring out a "runImpl" to be shared by the old PM and the new PM. Is that doable here to avoid some of the duplication?
Yeah, I saw that in the LoopVectorizer and it should be doable.  I decided against it because there is only a little duplication since ultimately they both delegate to the LoopDistributeForLoop class.  And when the old PM code goes away the runImpl thing would feel awkward.

But I am happy to make the change if you feel strongly about it.  And thanks for the reviews!


https://reviews.llvm.org/D22437