[llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 16:17:58 PDT 2016


> On 2016-Jul-15, at 15:42, Doug Gilmore <Doug.Gilmore at imgtec.com> wrote:
> 
>> From: Doug Gilmore
>> Sent: Friday, July 15, 2016 2:51 PM
>> To: llvm-commits at lists.llvm.org
>> Subject: Re: [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
>> 
>> [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
>> 
>>> Hmm.  Thanks for the revert and sorry for the trouble.
>>> 
>>> Please send a reproduction so I can investigate (assuming you can
>>> confirm this is the cause).  Likely this is a surprise end iterator
>>> being dereferenced somehow (I saw some of those in other patches,
>>> but caught the problem locally in the lit tests).
>> Hello Duncan and Daniel,
>> 
>> Whoops, I flubbed my (manual) bisect, r275141 is probably OK (I am in
>> the process of verifying that).
> Hi Duncan,
> 
> Your commit is OK:
> 
> https://dmz-portal.mips.com/bb/builders/LLVM%20with%20integrated%20assembler%20and%20fPIC%20and%20-O0/builds/803
> 
> So go ahead and recommit r275141 -- Thanks!

Reapplied in r275643.  Cheers.


More information about the llvm-commits mailing list