[PATCH] D21612: [compiler-rt] [XRay] Basic initialization and flag definition for XRay runtime

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 14:20:01 PDT 2016


echristo added inline comments.

================
Comment at: lib/xray/xray_interface.cc:37
@@ +36,3 @@
+  uint64_t Rrdi, Rrax, Rrdx, Rrsi, Rrcx, Rr8, Rr9, Rrbp;
+  __asm__ __volatile__("mov %%rbp, %0" : "=m"(Rrbp));
+  __asm__ __volatile__("mov %%rdi, %0" : "=m"(Rrdi));
----------------
Meta comment: Typically inline asm can be a single block rather than N statements of 1 per instruction.


https://reviews.llvm.org/D21612





More information about the llvm-commits mailing list