[PATCH] D22413: [ValueTracking] Teach isSafeToSpeculativelyExecute() about the speculatable attribute

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 09:57:22 PDT 2016


tstellarAMD added a comment.

I am planning to add the speculatable attribute to all the intrinsics listed in this function in a separate patch.

Do we want to also change this function to give information about speculatable cost as proposed in this review:  https://reviews.llvm.org/D20116

Another question I have is should the presence of speculatable by itself be enough for isSafeToSpeculativelyExecute() to return true.  This would mean that the callers would be responsible for checking memory dependencies before speculating.  The alternative would be to make isSafeToSpeculativelyExecute() require both the readnone and speculatable attributes.


https://reviews.llvm.org/D22413





More information about the llvm-commits mailing list