[llvm] r275538 - [ARM] Followup to r275537 addressing review comments

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 00:57:36 PDT 2016


Author: jamesm
Date: Fri Jul 15 02:57:35 2016
New Revision: 275538

URL: http://llvm.org/viewvc/llvm-project?rev=275538&view=rev
Log:
[ARM] Followup to r275537 addressing review comments

Address Chad's comment in D22216 which I missed due to tunnel vision on the "LGTM" comment.

Modified:
    llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=275538&r1=275537&r2=275538&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Fri Jul 15 02:57:35 2016
@@ -1849,8 +1849,8 @@ ARMTargetLowering::LowerCall(TargetLower
           false, false, 0);
     }
   } else if (isa<GlobalAddressSDNode>(Callee)) {
-    // If we're optimizing for minimum size and the function is called many
-    // times in this block, we can improve codesize by calling indirectly
+    // If we're optimizing for minimum size and the function is called three or
+    // more times in this block, we can improve codesize by calling indirectly
     // as BLXr has a 16-bit encoding.
     auto *GV = cast<GlobalAddressSDNode>(Callee)->getGlobal();
     auto *BB = CLI.CS->getParent();




More information about the llvm-commits mailing list