[PATCH] D22399: [LoopDataPrefetch/AArch64] Don't add prefetch intrinsic, when the loop already has InlineAsm prefetch.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 22:50:23 PDT 2016


hfinkel added inline comments.

================
Comment at: lib/Transforms/Scalar/LoopDataPrefetch.cpp:199
@@ +198,3 @@
+          // TODO: Need to check other architectures.
+          if (StringRef(IA->getAsmString()).startswith_lower("prfm"))
+            return MadeChange;
----------------
I think this would need to be some kind of TTI callback; we don't want to embed this kind of logic here. Also, I assume you'd need to check all of the lines, not just the first one.


https://reviews.llvm.org/D22399





More information about the llvm-commits mailing list