[PATCH] D22356: [ThinLTO] Perform index-based weak/linkonce resolution in import pass

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D22356#484213, @tejohnson wrote:

> As I just noted in https://reviews.llvm.org/D21545, that patch will have the side effect of enabling the linkonce/weak resolution for the distributed backend case. I like the way that patch adds the resolution before invoking the importer, instead of doing it via the FunctionImporter pass as is done here. However, it will expose the bug I am fixing here with the new PreserveNonPrevailing flag. I think I should probably change this patch just to fix that bug and add the new test case, and submit that just after https://reviews.llvm.org/D21545 goes in.
>
> As such, please review the patch ignoring the changes to Transforms/IPO/FunctionImport.cpp, which will go away once https://reviews.llvm.org/D21545 goes in.


Actually, I just realized that I can simulate the effect of https://reviews.llvm.org/D21545 without my FunctionImport pass changes via the right sequence of llvm-lto -thinlto-action invocations. Will rework the patch that way so that it can go in and hopefully fix this issue before https://reviews.llvm.org/D21545 goes in and exposes it.


https://reviews.llvm.org/D22356