[PATCH] D22326: [JumpThreading] PRE unordered loads

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 12:27:32 PDT 2016

sanjoy added a comment.

Will add the negative tests as you suggest.

Comment at: lib/Transforms/Scalar/JumpThreading.cpp:1059
@@ +1058,3 @@
+    LoadInst *NewVal =
+        new LoadInst(LoadedPtr, LI->getName() + ".pr", /*isVolatile*/ false,
+                     LI->getAlignment(), LI->getOrdering(), LI->getSynchScope(),
jfb wrote:
> Li->isVolatile() seems simpler than having the comment.
That sounds like an unrelated (to this patch) change.  I've removed the `/*isVolatile*/` comment for now (so that bit stays the same), let me know if you'd like me to `s/false/LI->isVolatile()/` separately.


More information about the llvm-commits mailing list