[PATCH] D22373: [GlobalISel] Introduce a simple instruction selector.

[Matthias Braun via llvm-commits]

MatzeB added a comment.

I just looked at the MachineRegisterInfo parts. This is also a highlevel comment, not necessarily about this patch (which just continues the current direction): It seems to me like generic regs and "normal" vregs don't have that much in common, they mostly share the same kind of MachineOperand and the same def/use lists. Apart from that they contain different information (register bank + size vs. register class). Wouldn't it make sense to introduce a new MachineOperand kind for them and separate them from "normal" vregs?


================
Comment at: lib/CodeGen/GlobalISel/InstructionSelect.cpp:38
@@ +37,3 @@
+
+static void reportSelectionError(const MachineInstr &MI, StringRef Message) {
+  const MachineFunction &MF = *MI.getParent()->getParent();
----------------
Twine Message?


https://reviews.llvm.org/D22373