[PATCH] D22249: Get rid of bool parameters in SelectionDAG::getLoad, getStore, and friends.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 02:04:49 PDT 2016

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM when the required dependencies finish and land. As others have said, thanks for the cleanup here!

Comment at: lib/Target/X86/X86ISelLowering.cpp:5606
@@ +5605,3 @@
+    auto MMOFlags = LDBase->getMemOperand()->getFlags();
+    assert(!(MMOFlags & MachineMemOperand::MOVolatile));
+    SDValue NewLd =
Nit: add a message to this assert along the lines of "Cannot merge volatile loads!"


More information about the llvm-commits mailing list