[PATCH] D21665: [LoopSimplify] Update LCSSA after separating nested loops.

Michael Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 19:10:04 PDT 2016


mzolotukhin added a comment.

Hi Sanjoy,

Thanks for review! You're right that we need to look not only at `NewBB` but in other blocks that happen to be outside the inner loop as well. I updated the test to check this case as well.

Also, I decided to make `processInstruction` from `LCSSA` externally available, since it greatly simplifies the patch. I'll submit the corresponding patch for a separate review (we'll need to iron out the API we want to have there), but I'll keep it here as well just to show you the complete picture.

Thanks,
Michael


http://reviews.llvm.org/D21665





More information about the llvm-commits mailing list