[PATCH] D22300: [ELF] Allow overriding reserved symbols in linker script

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 12:35:04 PDT 2016


ruiu added inline comments.

================
Comment at: test/ELF/linkerscript-symbols.s:4-7
@@ -3,6 +3,6 @@
 
-# RUN: echo "SECTIONS {.text : {*(.text.*)} text_end = .;}" > %t.script
+# RUN: echo "SECTIONS {.text : {*(.text.*)} end = .;}" > %t.script
 # RUN: ld.lld -o %t1 --script %t.script %t
 # RUN: llvm-objdump -t %t1 | FileCheck %s
-# CHECK: 0000000000000121         *ABS*    00000000 text_end
+# CHECK: 0000000000000121         *ABS*    00000000 end
 
----------------
Does this test check for the new code? I think you need two test cases, one is for symbol definition and the other is for symbol conflict.


Repository:
  rL LLVM

http://reviews.llvm.org/D22300





More information about the llvm-commits mailing list