[PATCH] D22288: ldd: Add GotEntrySize/GotPltEntrySize to ELF target

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: ELF/Target.cpp:314-317
@@ -313,4 +313,6 @@
   TlsOffsetRel = R_386_TLS_DTPOFF32;
   PltEntrySize = 16;
   PltHeaderSize = 16;
+  GotEntrySize = 4;
+  GotPltEntrySize = 4;
   TlsGdRelaxSkip = 2;
----------------
Please reorder so that the order matches the member definitions in the base class.

================
Comment at: ELF/Target.h:84-87
@@ -83,4 +83,6 @@
   uint32_t TlsOffsetRel;
   unsigned PltEntrySize;
   unsigned PltHeaderSize;
+  unsigned GotEntrySize;
+  unsigned GotPltEntrySize;
 
----------------
Sort

================
Comment at: ELF/Target.h:86-87
@@ -85,2 +85,4 @@
   unsigned PltHeaderSize;
+  unsigned GotEntrySize;
+  unsigned GotPltEntrySize;
 
----------------
Sort.


Repository:
  rL LLVM

http://reviews.llvm.org/D22288