[PATCH] D21932: [ThinLTO] Perform profile-guided indirect call promotion

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 15:39:25 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:97
@@ +96,3 @@
+          }
+        } else {
+          const CallInst *CI = dyn_cast<CallInst>(&I);
----------------
Add a one line comment for this code block?

================
Comment at: test/Transforms/PGOProfile/Inputs/thinlto_indirect_call_promotion.ll:3-4
@@ +2,4 @@
+target triple = "x86_64-unknown-linux-gnu"
+
+ at foo = common local_unnamed_addr global void ()* null, align 8
+
----------------
I'm not sure why you need this definition?


http://reviews.llvm.org/D21932





More information about the llvm-commits mailing list