[PATCH] D22280: [PM] Convert LoopInstSimplify Pass to new PM

[Sean Silva via llvm-commits]

silvas added a subscriber: silvas.
silvas added a comment.

LGTM.

One tip is that usually you don't need to rename to "LegacyPass" unless the existing name conflicts.
I.e. usually the old PM class will be called e.g. LoopInstSimplify, the new one will be called LoopInstSimplifyPass, and so there is no conflict. This avoids a little bit of work when porting passes.

Also, for the record, the current remaining passes needed for the per-TU O3 pipeline are:

- Loop Distribution
- Loop Load Elimination
- Loop Unswitch (this one may be harder since it needs "addLoop" API on loop pass manager; it may be possible to make addLoop a no-op in the new PM with a FIXME; for example, Loop Distribution does not call addLoop (probably a bug... but it is the current state))
- Loop Unroll (I have a patch locally that I'll commit soon once I finish debugging some issues with the new PM)

(After Loop Unroll together with http://reviews.llvm.org/D21483 I can now run LLD's entire LTO pipeline with the new PM! (and start to debug the issues :) ) )


http://reviews.llvm.org/D22280