[llvm] r275179 - [MC] Flip llc's assembly comment preservation flag to have consistent

[Eric Christopher via llvm-commits]

On Tue, Jul 12, 2016 at 8:39 AM Nirav Dave via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: niravd
> Date: Tue Jul 12 10:32:36 2016
> New Revision: 275179
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275179&view=rev
> Log:
> [MC] Flip llc's assembly comment preservation flag to have consistent
> orientation with llvm-mc.
>
> Modified:
>     llvm/trunk/tools/llc/llc.cpp
>
> Modified: llvm/trunk/tools/llc/llc.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llc/llc.cpp?rev=275179&r1=275178&r2=275179&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/llc/llc.cpp (original)
> +++ llvm/trunk/tools/llc/llc.cpp Tue Jul 12 10:32:36 2016
> @@ -74,8 +74,9 @@ NoIntegratedAssembler("no-integrated-as"
>                        cl::desc("Disable integrated assembler"));
>
>  static cl::opt<bool>
> -    NoPreserveComments("fno-preserve-as-comments", cl::Hidden,
> -                       cl::desc("Preserve Comments in outputted
> assembly"));
> +    PreserveComments("fpreserve-as-comments", cl::Hidden,
> +                     cl::desc("Preserve Comments in outputted assembly"),
> +                     cl::init(true));
>
>
No f please. There's no reason.

Thanks.

-eric


>  // Determine optimization level.
>  static cl::opt<char>
> @@ -336,7 +337,7 @@ static int compileModule(char **argv, LL
>    Options.MCOptions.ShowMCEncoding = ShowMCEncoding;
>    Options.MCOptions.MCUseDwarfDirectory = EnableDwarfDirectory;
>    Options.MCOptions.AsmVerbose = AsmVerbose;
> -  Options.MCOptions.PreserveAsmComments = !NoPreserveComments;
> +  Options.MCOptions.PreserveAsmComments = PreserveComments;
>
>    std::unique_ptr<TargetMachine> Target(
>        TheTarget->createTargetMachine(TheTriple.getTriple(), CPUStr,
> FeaturesStr,
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160712/dc26f5de/attachment.html>