[PATCH] D22269: [SCCP] Replace structs with constants if all the lattice values are constant

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 12:16:38 PDT 2016


davide marked an inline comment as done.
davide added a comment.

In http://reviews.llvm.org/D22269#481969, @eli.friedman wrote:

> You probably want to refactor this if you're planning to use it from IPSCCP... but you can do that in the followup, I guess.


Yes, I'll refactor separately.

> In terms of expanding the struct code for vectors, I guess that might work?  It's probably a lot of work for not much benefit, though; it would involve touching every single operation which can work on vectors (including basically every arithmetic operator).


I'm still unsure as well. Now that I have a slightly better understanding of the pass I might try  that and see where it goes. If it's too complicated I'll just avoid doing that.


http://reviews.llvm.org/D22269





More information about the llvm-commits mailing list