[PATCH] D22182: Refactor indirect call promotion profitability analysis (NFC)

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

I am testing the fixed patch, should upload it shortly.


================
Comment at: lib/Analysis/IndirectCallPromotionAnalysis.cpp:69
@@ +68,3 @@
+                                   cl::desc("Run indirect-call promotion for "
+                                            "invoke instruction only"));
+
----------------
davidxl wrote:
> tejohnson wrote:
> > xur wrote:
> > > icp-call-only and -icp-invoke-only are mainly for debug. I think it's better to keep together with the transformation code.
> > Why not have them here and prevent adding the ThinLTO edges in the debug case?
> sounds ok to put them here.
Actually, after discussing with Rong, I have moved these back.


http://reviews.llvm.org/D22182