[PATCH] D21995: [ELF] Implement minimal PHDRS parser and section-to-segment assignment

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 07:21:45 PDT 2016


evgeny777 added inline comments.

================
Comment at: ELF/LinkerScript.cpp:286
@@ +285,3 @@
+  ssize_t RelroNum = -1;
+  Phdr *Load = nullptr;
+  uintX_t Flags = PF_R;
----------------
Well, ErrorOr<T> looks a way too heavy to represent valid/invalid array index, doesn't it?



http://reviews.llvm.org/D21995





More information about the llvm-commits mailing list