[PATCH] D22030: [PGO] Change the ProfileSummary metadata merge behavior

Jake VanAdrighem via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 19:50:50 PDT 2016


jakev added a comment.

In http://reviews.llvm.org/D22030#478216, @eraman wrote:

> I am trying to understand the use case here. Do you need to support a case where you compile different modules with different profiles and LTO them together? Isn't merging the profiles and using the merged profile an option there?


Apologies for the delay.

After some discussion about this with silvas offline, it seems that leaving the current behavior might be the easiest way to loudly inform users of the profile metadata mismatch. My initial concern was that, as a matter of principle, builds shouldn't fail due to stale profile information. LTO or otherwise. Since this is apparently a non-issue, I'll abandon the patch. Sorry for kicking up dust.


Repository:
  rL LLVM

http://reviews.llvm.org/D22030





More information about the llvm-commits mailing list