[PATCH] D21932: [ThinLTO] Perform profile-guided indirect call promotion

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 17:17:26 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:366
@@ +365,3 @@
+  // Indirect call promotion that promotes intra-module targets only.
+  MPM.add(createPGOIndirectCallPromotionLegacyPass());
+
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > Is this totally related to this patch or is it already an existing mistake? (I.e. could be committed separately?)
> > 
> > Also remove braces for the if block.
> It could be committed earlier but would be a no-op without the rest of this patch (unless we happened to import a function that was called directly but also happened to be called indirectly).
> 
> Will remove braces.
I see, it also runs during the compile phase so it'll only apply to imported function here. That's fine as-is then.


http://reviews.llvm.org/D21932





More information about the llvm-commits mailing list