[PATCH] D21764: AMDGPU: Remove superfluous string attributes from tests

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 16:43:13 PDT 2016


arsenm closed this revision.
arsenm marked 2 inline comments as done.
arsenm added a comment.

r275129


================
Comment at: test/CodeGen/AMDGPU/fmul.ll:1
@@ -1,2 +1,2 @@
-; RUN: llc -march=amdgcn -mcpu=SI -verify-machineinstrs < %s | FileCheck -check-prefix=SI -check-prefix=FUNC %s
-; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck -check-prefix=SI -check-prefix=FUNC %s
+; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=GCN -check-prefix=FUNC %s
+; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck -check-prefix=GCN -check-prefix=FUNC %s
----------------
nhaehnle wrote:
> Isn't it better to be explicit about -mcpu? Not that I care strongly either way...
It doesn't really matter, the default is just tahiti. I don't think most tests specify for SI


http://reviews.llvm.org/D21764





More information about the llvm-commits mailing list