[PATCH] D21299: [Codegen Prepare] Swap commutative binops before splitting branch condition.

Balaram Makam via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 15:12:09 PDT 2016


bmakam added a comment.

In http://reviews.llvm.org/D21299#480901, @rengolin wrote:

> If all cores that have FeaturePredictableSelectIsExpensive can also have the new flag, and it makes sense, it could be coalesced into a single flag?


FWIW, PredictableSelectIsExpensive is also set in X86ISelLowering.cpp: PredictableSelectIsExpensive = Subtarget.getSchedModel().isOutOfOrder()
I created a new flag because I could not verify the profitability of this patch on x86 target.  I agree if it makes sense to enable it for x86, we could coalesce into a single flag.


http://reviews.llvm.org/D21299





More information about the llvm-commits mailing list