[PATCH] D22182: Refactor indirect call promotion profitability analysis (NFC)

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: include/llvm/Analysis/IndirectCallPromotionAnalysis.h:60
@@ +59,3 @@
+  ArrayRef<InstrProfValueData>
+  getPromotionCandidatesForInstruction(const Instruction *I, uint32_t &NumVals,
+                                       uint64_t &TotalCount,
----------------
xur wrote:
> davidxl wrote:
> > This analysis does not check legality, why is that?
> I guess this can be a super set of the real transformations. this just to add edges.
Because the legality check is based on the target function, and this is being refactored so that it can be called when the target function is not yet known (when building the summary in the ThinLTO compile step where it is an inter-module indirect call).


http://reviews.llvm.org/D22182