[PATCH] D21772: New pass manager for LICM.

[Dehao Chen via llvm-commits]

danielcdh added a comment.

oops, drafted the comments few days ago but forgot to hit "Submit"...


================
Comment at: test/Transforms/LICM/hoist-deref-load.ll:2
@@ -1,2 +1,3 @@
 ; RUN: opt -S -basicaa -licm < %s | FileCheck %s
+; RUN: opt -loop-simplifycfg %s | opt -aa-pipeline=basic-aa -passes='require<aa>,require<targetir>,require<scalar-evolution>,loop(licm)' -S | FileCheck %s
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
silvas wrote:
> You can do `loop(simplify-cfg,licm)`
Unfortunately, the loop-simplifycfg pass behaviors quite differently under the new PM:

opt -passes='require<domtree>,loop(simplify-cfg)' test/Transforms/LICM/hoist-deref-load.ll -S > 1
opt -loop-simplifycfg test/Transforms/LICM/hoist-deref-load.ll -S > 2

The output 1 and 2 are quite different. Am I missing something when invoking it in the new PM?


http://reviews.llvm.org/D21772