[PATCH] D22158: Mips: Avoid implicit iterator conversions, NFC

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 01:58:42 PDT 2016


dsanders accepted this revision.
dsanders added a reviewer: dsanders.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/Mips/MipsConstantIslandPass.cpp:803
@@ -806,5 +802,3 @@
 
-  for (MachineBasicBlock::iterator I = MBB->begin(), E = MBB->end(); I != E;
-       ++I)
-    BBI.Size += TII->GetInstSizeInBytes(I);
-
+  for (MachineInstr &MI : *MBB)
+    BBI.Size += TII->GetInstSizeInBytes(MI);
----------------
Can this one be const?


http://reviews.llvm.org/D22158





More information about the llvm-commits mailing list