[PATCH] D9401: llvm.noalias - The AA implementaton

[David Majnemer via llvm-commits]

majnemer added a comment.

I've reviewed this to my satisfaction but you will need a more thorough review by an AA expert.


================
Comment at: lib/Analysis/ScopedNoAliasAA.cpp:316
@@ +315,3 @@
+  for (auto &C : Children) {
+    SmallPtrSet<const Value *, 16> ChildVisited(Visited.begin(), Visited.end());
+    ChildVisited.insert(P);
----------------
Might be good to hoist this out of the loop and clear it at the start of the loop.  Saves you having to reallocate if the set goes big.

================
Comment at: lib/Analysis/ScopedNoAliasAA.cpp:319
@@ +318,3 @@
+
+    SmallVector<Instruction *, 8> ChildCompatSet;
+    if (!findCompatibleNoAlias(C, ANoAlias, BNoAlias, DL, ChildVisited,
----------------
Ditto with this vector.


http://reviews.llvm.org/D9401