[llvm] r274958 - [CFLAA] Move the graph builder out from CFLSteens. NFC.

[George Burgess IV via llvm-commits]

Thanks for the heads-up!

Looks like a 'const' got dropped when it shouldn't have been. Let's see if
r274961 fixes the issue. :)

On Fri, Jul 8, 2016 at 11:19 PM, Davide Italiano <davide at freebsd.org> wrote:

> On Fri, Jul 8, 2016 at 7:54 PM, George Burgess IV via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: gbiv
> > Date: Fri Jul  8 21:54:42 2016
> > New Revision: 274958
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=274958&view=rev
> > Log:
> > [CFLAA] Move the graph builder out from CFLSteens. NFC.
> >
> > Patch by Jia Chen.
> >
> > Differential Revision: http://reviews.llvm.org/D22022
> >
> > Modified:
> >     llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h
> >     llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h
> >     llvm/trunk/lib/Analysis/AliasAnalysisSummary.h
> >     llvm/trunk/lib/Analysis/CFLGraph.h
> >     llvm/trunk/lib/Analysis/CFLSteensAliasAnalysis.cpp
> >
> > Modified: llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h?rev=274958&r1=274957&r2=274958&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h (original)
> > +++ llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h Fri Jul  8
> 21:54:42 2016
> > @@ -21,12 +21,23 @@
> >
> >  namespace llvm {
> >
> > +namespace cflaa {
> > +struct AliasSummary;
> > +}
> > +
> >  class CFLAndersAAResult : public AAResultBase<CFLAndersAAResult> {
> >    friend AAResultBase<CFLAndersAAResult>;
> >
> >  public:
> >    explicit CFLAndersAAResult();
> >
> > +  /// \brief Get the alias summary for the given function
> > +  /// Return nullptr if the summary is not found or not available
> > +  const cflaa::AliasSummary *getAliasSummary(Function &Fn) {
> > +    // Dummy implementation
> > +    return nullptr;
> > +  }
> > +
> >    AliasResult alias(const MemoryLocation &LocA, const MemoryLocation
> &LocB) {
> >      // Dummy implementation
> >      return AAResultBase::alias(LocA, LocB);
> >
> > Modified: llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h?rev=274958&r1=274957&r2=274958&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h (original)
> > +++ llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h Fri Jul  8
> 21:54:42 2016
> > @@ -29,6 +29,10 @@ namespace llvm {
> >
> >  class TargetLibraryInfo;
> >
> > +namespace cflaa {
> > +struct AliasSummary;
> > +}
> > +
> >  class CFLSteensAAResult : public AAResultBase<CFLSteensAAResult> {
> >    friend AAResultBase<CFLSteensAAResult>;
> >    class FunctionInfo;
> > @@ -52,6 +56,10 @@ public:
> >    /// Returns the appropriate entry from the cache.
> >    const Optional<FunctionInfo> &ensureCached(Function *Fn);
> >
> > +  /// \brief Get the alias summary for the given function
> > +  /// Return nullptr if the summary is not found or not available
> > +  const cflaa::AliasSummary *getAliasSummary(Function &Fn);
> > +
> >    AliasResult query(const MemoryLocation &LocA, const MemoryLocation
> &LocB);
> >
> >    AliasResult alias(const MemoryLocation &LocA, const MemoryLocation
> &LocB) {
> >
> > Modified: llvm/trunk/lib/Analysis/AliasAnalysisSummary.h
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/AliasAnalysisSummary.h?rev=274958&r1=274957&r2=274958&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/lib/Analysis/AliasAnalysisSummary.h (original)
> > +++ llvm/trunk/lib/Analysis/AliasAnalysisSummary.h Fri Jul  8 21:54:42
> 2016
> > @@ -36,6 +36,7 @@
> >  #define LLVM_ANALYSIS_ALIASANALYSISSUMMARY_H
> >
> >  #include "llvm/ADT/Optional.h"
> > +#include "llvm/ADT/SmallVector.h"
> >  #include "llvm/IR/CallSite.h"
> >  #include <bitset>
> >
> > @@ -96,6 +97,9 @@ AliasAttrs getExternallyVisibleAttrs(Ali
> >  // Function summary related stuffs
> >
> //===----------------------------------------------------------------------===//
> >
> > +/// The maximum number of arguments we can put into a summary.
> > +static unsigned MaxSupportedArgsInSummary = 50;
> > +
>
>
> GCC6 complains :(
> [15/52] Building CXX object
> lib/Analysis/CMakeFiles/LLVMAnalysis.dir/AliasAnalysisSummary.cpp.o
> In file included from ../lib/Analysis/AliasAnalysisSummary.cpp:1:0:
> ../lib/Analysis/AliasAnalysisSummary.h:101:17: warning:
> ‘llvm::cflaa::MaxSupportedArgsInSummary’ defined but not used
> [-Wunused-variable]
>  static unsigned MaxSupportedArgsInSummary = 50;
>                  ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> It could be a false positive, but, just in case, can you please take a
> look?
>
> Thanks!
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160708/3d20acdb/attachment.html>