[PATCH] D9377: llvm.noalias - don't block EarlyCSE

[Hal Finkel via llvm-commits]

hfinkel updated this revision to Diff 63337.
hfinkel added a comment.
Herald added a subscriber: mcrosier.

Rebased.


http://reviews.llvm.org/D9377

Files:
  lib/Transforms/Scalar/EarlyCSE.cpp
  test/Transforms/EarlyCSE/basic.ll

Index: test/Transforms/EarlyCSE/basic.ll
===================================================================
--- test/Transforms/EarlyCSE/basic.ll
+++ test/Transforms/EarlyCSE/basic.ll
@@ -53,6 +53,16 @@
   ; CHECK: ret i32 0
 }
 
+; CHECK-LABEL: @test2b(
+define i32 @test2b(i32 *%P, i1 %b) {
+  %V1 = load i32, i32* %P
+  call i8* @llvm.noalias.p0i8(i8* undef, metadata !1)
+  %V2 = load i32, i32* %P
+  %Diff = sub i32 %V1, %V2
+  ret i32 %Diff
+  ; CHECK: ret i32 0
+}
+
 ;; Cross block load value numbering.
 ; CHECK-LABEL: @test3(
 define i32 @test3(i32 *%P, i1 %Cond) {
@@ -133,6 +143,15 @@
   ; CHECK: ret i32 42
 }
 
+; CHECK-LABEL: @test6b(
+define i32 @test6b(i32 *%P, i1 %b) {
+  store i32 42, i32* %P
+  call i8* @llvm.noalias.p0i8(i8* undef, metadata !1)
+  %V1 = load i32, i32* %P
+  ret i32 %V1
+  ; CHECK: ret i32 42
+}
+
 ;; Trivial dead store elimination.
 ; CHECK-LABEL: @test7(
 define void @test7(i32 *%P) {
@@ -276,3 +295,8 @@
   ret void
 }
 
+declare i8* @llvm.noalias.p0i8(i8*, metadata) nounwind
+
+!0 = !{!0, !"some domain"}
+!1 = !{!1, !0, !"some scope"}
+
Index: lib/Transforms/Scalar/EarlyCSE.cpp
===================================================================
--- lib/Transforms/Scalar/EarlyCSE.cpp
+++ lib/Transforms/Scalar/EarlyCSE.cpp
@@ -556,9 +556,10 @@
     // Skip assume intrinsics, they don't really have side effects (although
     // they're marked as such to ensure preservation of control dependencies),
     // and this pass will not disturb any of the assumption's control
-    // dependencies.
-    if (match(Inst, m_Intrinsic<Intrinsic::assume>())) {
-      DEBUG(dbgs() << "EarlyCSE skipping assumption: " << *Inst << '\n');
+    // dependencies. Likewise, noalias intrinsics don't actually write.
+    if (match(Inst, m_CombineOr(m_Intrinsic<Intrinsic::noalias>(),
+                                m_Intrinsic<Intrinsic::assume>()))) {
+      DEBUG(dbgs() << "EarlyCSE skipping intrinsic: " << *Inst << '\n');
       continue;
     }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9377.63337.patch
Type: text/x-patch
Size: 1991 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160708/f9808e02/attachment.bin>