[PATCH] D22079: Refactor Archive-child iteration.

[Lang Hames via llvm-commits]

lhames updated this revision to Diff 63325.
lhames added a comment.

Switched findSym from:

  child_iterator findSym(Error &Err, StringRef Name)

to:

  Expected<Optional<Child>> findSym(StringRef Name)

And made child_iterator's non-iterable constructor (representing the end iterator value) private so that only Archive::child_end can construct it.


Repository:
  rL LLVM

http://reviews.llvm.org/D22079

Files:
  include/llvm/Object/Archive.h
  include/llvm/Support/Error.h
  lib/ExecutionEngine/MCJIT/MCJIT.cpp
  lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
  lib/Object/Archive.cpp
  lib/Support/Error.cpp
  tools/dsymutil/BinaryHolder.cpp
  tools/llvm-ar/llvm-ar.cpp
  tools/llvm-cxxdump/llvm-cxxdump.cpp
  tools/llvm-nm/llvm-nm.cpp
  tools/llvm-objdump/MachODump.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  tools/llvm-readobj/llvm-readobj.cpp
  tools/llvm-size/llvm-size.cpp
  tools/sancov/sancov.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22079.63325.patch
Type: text/x-patch
Size: 33786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160708/0c4c0ed1/attachment-0001.bin>