[PATCH] D22112: Disambiguate a constant with both 0B prefix and H suffix.

Colin LeMahieu via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 14:19:39 PDT 2016

colinl added a comment.

It looks like in X86MCAsmInfo.cpp AsmWriterFlavor controls AssemblerDialect which is tied with [Intel|ATT]AsmParserVariant in X86.td

My gut feel is allowing both suffix and prefix to coexist with one winning out in certain circumstances is error prone in addition to expanding the accepted syntax beyond what other assemblers accept.

It seems like the MCAsmInfo flag would control whether the parser would accept either the prefix or postfix radix specifications though not both and when the Intel/ATT syntax variant is chosen it would pick the appropriate radix parsing function.

What do you think?


More information about the llvm-commits mailing list