[PATCH] D21514: Rationalise the attribute getter/setter methods on Function and CallSite.
    Akira Hatanaka via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Jul  8 13:20:03 PDT 2016
    
    
  
ahatanak added a subscriber: ahatanak.
================
Comment at: include/llvm/IR/CallSite.h:312
@@ -311,3 +311,1 @@
 
-  void addAttribute(unsigned i, StringRef Kind, StringRef Value) {
-    CALLSITE_DELEGATE_SETTER(addAttribute(i, Kind, Value));
----------------
What's the reason you are removing this method, but not removeAttribute(unsigned i, StringRef Kind)? Since you are trying to make the API more consistent, it seems to me that you should remove that too or keep this one?
http://reviews.llvm.org/D21514
    
    
More information about the llvm-commits
mailing list