[PATCH] D19287: Remove inline hints computation from SampleProfile.cpp

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 13:03:17 PDT 2016

danielcdh added inline comments.

Comment at: lib/Transforms/IPO/SampleProfile.cpp:86
@@ -85,3 @@
-static cl::opt<double> SampleProfileGlobalColdThreshold(
-    "sample-profile-global-cold-threshold", cl::init(0.5), cl::value_desc("N"),
-    cl::desc("Top-level functions that account for less than N% of all samples "
eraman wrote:
> Note that the behavior will be different because the threshold for determining cold in ProfileSummary is 1% of max function count and here it is 0.5%. I think this shouldn't matter much, but it is something to be aware of. 
Thanks for the reminder. This should not affect performance much, and shortly we will use callsite hotness for inline cost.


More information about the llvm-commits mailing list