[PATCH] D22122: [SCCP] Teach the pass about bitcasts

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 12:41:54 PDT 2016

davide added a comment.

In http://reviews.llvm.org/D22122#478539, @eli.friedman wrote:

> > SCCP doesn't handle vectors. There's some code for it but it's #if 0'd . I re-enabled that code and tried to build and it passes test suite and it's able to self-host LLVM, so, I'm not entirely sure why that code is disabled and the comments in the code don't help :| Do you happen to know what's the reason?
> Just skimming the code, it looks wrong.  Specifically, it looks like it's doing screwy things with undefined values.  (Neither LLVM itself or the test-suite are very good tests for vector workloads.)

Thanks for the pointer. I'll try to rewrite those bits and propose a patch soon. Thanks! I'll also be sure to test on something that tests vector workloads.



More information about the llvm-commits mailing list