[PATCH] D21405: [PGO] IRPGO pre-cleanup pass changes

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:213
@@ +212,3 @@
+  if (SizeOptLevel == 1) // -Os
+    return 75;
+  if (SizeOptLevel == 2) // -Oz
----------------
Do you have text size comparison (for profile-use phase) with and without pre-cleanup? If pre-cleanup always reduces final size, there is no need to special case here. If not, we should disable pre-cleanup with Os or Oz is specified. 

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:216
@@ +215,3 @@
+    return 25;
+  return 75;
+}
----------------
Needs to have an option to control the value.


http://reviews.llvm.org/D21405