[PATCH] D22108: AMDGPU: Only use legal inline immediates with kill pseudo

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 10:25:07 PDT 2016

nhaehnle added a comment.

I agree, but the D3D designers in their infinite wisdom designed a KILL opcode with a floating point parameter, which we inherited via TGSI in Mesa, which in turn motivated this (indeed somewhat questionable) intrinsic.

Hmm. My concern is that (non-constant) KILL gets lowered to a floating point comparison, which treats NaNs specially. (i32)-1 is a NaN. I admit that it doesn't really matter since this patch uses a constant, but it still leaves me with an uncomfortable feeling.


More information about the llvm-commits mailing list