[PATCH] D21949: [SystemZ] Utilize Test Data Class instructions.

[Ulrich Weigand via llvm-commits]

uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D21949#477158, @koriakin wrote:

> More tests


Ah, so your code already recognized those cases, excellent :-)

See the inline comments.  Otherwise, this looks really good to me.  Thanks!


================
Comment at: lib/Target/SystemZ/SystemZTDC.cpp:141
@@ +140,3 @@
+    // Likewise for infinities.
+    WhichConst = Const->isNegative() ? 2 : 1;
+  } else if (Const->isExactlyValue(Smallest)) {
----------------
Do we need to check for impossible comparisons here (like x > inf)?

================
Comment at: lib/Target/SystemZ/SystemZTDC.cpp:165
@@ +164,3 @@
+    0,     0xee0, 0x110, 0x00f, // -minnorm
+  };
+  // Construct the mask as a combination of the partial masks.
----------------
These mask constants are a bit hard to read.  It would be nicer to define symbolic constants for the various TDC mask bits ...


Repository:
  rL LLVM

http://reviews.llvm.org/D21949