[PATCH] D21468: Fixed LegacyPassManager inconsistency

Jesper Antonsson via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 01:47:34 PDT 2016

JesperAntonsson added a comment.

Whether this is the the right fix or band-aid is a fair question. :-)  The problematic operation seems to be the transitive update of LastUser, and that's what I'm restraining in a minimal way to retain consistency with preservation info. OTOH, I don't understand/like the transitive update at all, but perhaps you understand its implications and what, if anything, would need to be done if it were to be removed entirely? There are other possibilities as well but I guess those would require more fundamental redesign.

I'm going for vacation at the end of this work day. I'll be back mid August and won't do anything more until then, but if you find this patch the right way to go, please feel free to push it at any time. (I don't have commit rights yet anyway, so I need help with that.)

Thanks, and have a great summer!  /Jesper


More information about the llvm-commits mailing list