[PATCH] D22114: [InstCombine] extend vector select matching for non-splat constants

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 16:41:32 PDT 2016

eli.friedman added inline comments.

Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1601
@@ +1600,3 @@
+    // One element must be all ones, and the other must be all zeros.
+    if (!((match(EltC1, m_Zero()) && match(EltC2, m_AllOnes())) ||
spatel wrote:
> eli.friedman wrote:
> > What if one is undef?
> Ah, right. Or even both elts could be undef?
> Ok to make that a FIXME comment for this patch? I'll follow-up with the extra logic and test cases.


More information about the llvm-commits mailing list