[PATCH] D22115: Teach FastISel about thiscall (and, hence, about callee-pop).

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 16:14:35 PDT 2016

rnk added a comment.

In http://reviews.llvm.org/D22115#477488, @thakis wrote:

> In http://reviews.llvm.org/D22115#477460, @rnk wrote:
> > Can we test the case when the parameters are greater than 64KB? Is there some other example test that deals with the cases where we bail out?
> Added a test for the 64kB, based on x86-big-ret.ll. (I'm not sure I understand what you mean with the second question -- do you want more tests, or do you mean as example for how to do the 64kB test?)

I'm not sure what the best way is to test fast isel fallback, so I was asking if there are similar tests nearby that do it well. A lot of fastisel tests use -fast-isel-abort so that they fail if we stop being able to select simple code sequences.


More information about the llvm-commits mailing list