[PATCH] D21464: [PM] WIP: Introduce basic update capabilities to the new PM's CGSCC pass manager, including both plumbing and logic to handle function pass updates.
Chandler Carruth via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 7 15:31:08 PDT 2016
On Thu, Jun 30, 2016 at 6:36 PM Daniel Berlin via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
>> 4. The patch introduces a new SCC formation algorithm (double layer with
>> support for CG mutation on the fly), however design document on how this
>> works is missing. It needs to document
>> * What exactly is expected (in terms of vistation order) when a) an
>> edge is added; b) an edge is deleted; c) when a new node is introduced and
>> * How ref-edges are formed, how indirect callsites are handled etc.
>> * If it is a modification of the classic SCC formation algorithm,
>> describe the change and prove that the algorithm works as expected.
> FWIW: I agree that for algorithms this complex, where we have no other
> reference for how they are supposed to work, and no way to know what
> invariants make them correct or not (other than reading code), we should
> have some design doc.
Please see my response to David, there is no disagreement here.
> In this case, it should not be hard to prove that you can validly form
> both ref and non-ref SCC's at once:
I'd really like to move this to a separate discussion of LCG. Maybe in
response to a separate patch that adds the needed documentation.
I'm fine if that has to conclude before we review this patch, but this
patch is pretty much exclusively using the LCG API to do updates.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits