[PATCH] D21935: Add TLI.allowsMisalignedMemoryAccesses to LoadStoreVectorizer

Alina Sbirlea via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 14:59:17 PDT 2016

asbirlea added inline comments.

Comment at: test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll:505
@@ -504,4 +504,3 @@
 ; CHECK-LABEL: @merge_local_store_2_constants_i32_align_2
-; CHECK: store i32
-; CHECK: store i32
+; CHECK: store <2 x i32> <i32 456, i32 123>, <2 x i32> addrspace(3)* %1, align 2
 define void @merge_local_store_2_constants_i32_align_2(i32 addrspace(3)* %out) #0 {
arsenm wrote:
> arsenm wrote:
> > asbirlea wrote:
> > > This is no longer vectorized with the above changes. I will update it with the other tests.
> > I recently enabled misaligned access depending on the triple, so this should probably be vectorized?
> Never mind, I misread which test this is
I believe due to what you enabled, the tests ending in "_natural_align" are now vectorizing. They don't vectorize without the triple argument.
I'm still not clear why/if the vectorization is correct. Would you mind taking a look to confirm?
I can update the (4) tests in that case.


More information about the llvm-commits mailing list