[PATCH] D22001: [DSE] Remove dead stores in end blocks containing fence
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 7 10:28:38 PDT 2016
reames added a comment.
In http://reviews.llvm.org/D22001#476915, @jfb wrote:
> I'm not sure I understand the mentions of end block. Why is this relevant? A dead store is dead, regardless of successors. Could you explain?
> If it is relevant, I'd like to see a test that explains the relevance, and makes sure correctness is retained if there is a successor.
The relevance is in the context of the existing code. The current code *detects* that stores are dead by walking backwards from the terminator of a block without successors (end block) and looking for unobserved stores to function local objects.
More information about the llvm-commits