[PATCH] D21894: [ELF] - Fixed incorrect logic of version assignments when mixing wildcards with values matching.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 00:32:03 PDT 2016

grimar added inline comments.

Comment at: ELF/SymbolTable.cpp:599
@@ +598,3 @@
+        warning("duplicate symbol " + Name + " in version script");
+      B->symbol()->VersionId = I + 2;
+    }
ruiu wrote:
> You don't have to do this in this patch, but `+ 2` seems too magical and needs to be handled in a better way. I think it is better to add `VersionId` member to `Version` struct and store the version id to that member.
I`ll prepare a patch.


More information about the llvm-commits mailing list