[PATCH] D22030: [PGO] Change the ProfileSummary metadata merge behavior

Jake VanAdrighem via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 20:16:58 PDT 2016

jakev added a comment.

In http://reviews.llvm.org/D22030#475831, @eraman wrote:

> All the modules are expected to have the same profile summary and changing the behavior to a warning is not the right thing to do. If we want to support a use case where we LTO files with different profile data, perhaps we should have a way to disable profile summary for those builds? That seems better than picking the first summary we see (as would be the case with a warning)

Yeah that seems reasonable. I'm not sure what the right way to do this is, but dropping the ProfileSummary metadata and giving up on any further merging when we encounter a conflict seems like the right idea. What do you think is the correct path forward here?



More information about the llvm-commits mailing list