[PATCH] D22071: Correct ordering of loads/stores.

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 20:13:58 PDT 2016

arsenm added inline comments.

Comment at: test/Transforms/LoadStoreVectorizer/AMDGPU/insertion-point.ll:12
@@ -12,2 +11,3 @@
+; CHECK: %w = add i32 %y, 9
 ; CHECK: %foo = add i32 %z, %w
 define void @insert_load_point(float addrspace(1)* nocapture %a, float addrspace(1)* nocapture %b, float addrspace(1)* nocapture readonly %c, i64 %idx, i32 %x, i32 %y) #0 {
jlebar wrote:
> > It looks to me it is intentionally testing an implementation detail ("insert_load_point").
> Looks like it to me, too.  When we committed the original patches, we all agreed that we wouldn't act with a bias towards the existing code, since we committed with existing unresolved issues.  I think this should count under that rubric.
> That is, can we fix the test so it no longer tests an implementation detail?  I suppose you don't need to do that in this patch if you don't want.
The pass should still have an expectation for where the instructions will be inserted relative to the originals, I think a test ensuring this is useful


More information about the llvm-commits mailing list