[PATCH] D22074: GlobalISel: legalization policy class

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 16:47:58 PDT 2016


t.p.northover created this revision.
t.p.northover added reviewers: arsenm, qcolombet.
t.p.northover added a subscriber: llvm-commits.
t.p.northover set the repository for this revision to rL LLVM.
Herald added subscribers: mcrosier, vkalintiris, mehdi_amini, aemerson.

Hi,

As suggested in D21534, I've split off the class deciding on how legalization should proceed (plus the legalizeInstr stub) into a separate unit-tested patch.

I've addressed most of the relevant comments from the original diff, with two outstanding issues:

  * We'll need a richer setAction interface to cope with multiple types on instructions.
  * Similarly, we'll need to be able to cope with per-address-space legalization.

I fully agree with both of these, but think they'll probably be added organically as we grow (certainly the first is needed for AArch64, and I'll make sure the second doesn't get neglected).

As with most of the other GlobalISel things, it's pretty rough around the edges as a prototype and I'm hoping to fill in the details as-needed and as-testable.

Tim.

Repository:
  rL LLVM

http://reviews.llvm.org/D22074

Files:
  include/llvm/CodeGen/GlobalISel/MachineLegalizer.h
  include/llvm/CodeGen/LowLevelType.h
  lib/CodeGen/GlobalISel/CMakeLists.txt
  lib/CodeGen/GlobalISel/MachineLegalizer.cpp
  unittests/CodeGen/CMakeLists.txt
  unittests/CodeGen/GlobalISel/CMakeLists.txt
  unittests/CodeGen/GlobalISel/MachineLegalizerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22074.62996.patch
Type: text/x-patch
Size: 16669 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160706/7935f3be/attachment.bin>


More information about the llvm-commits mailing list